Fix intersection mechanic around floating-point limit. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
might not work with fast intersector for now (which is not used in opencl)
simply break when bbox distance is greater than current current intersection distance.
…inside true surface
…t with same-solid distance condition which cancels back catch (and all intersections for that matter) if there is an intersection further away that sends the photon towards its current environment.
JLBegin
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes most of the intersection behavior at the smaller scale (around floating point limit) to address many issues like photons leaving a geometry without intersecting, photons getting stuck (refraction loop), photons surfing (reflection loop) and general energy conservation issues.
Other aspects of the propagation and large-scale intersection logic were also fixed along the way.
Extensively tested in extreme cases with small structures and very low scattering distances (up to mu_t around 1000).
Changes